feat: support compile torchair graph while warming up #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeverRaR
force-pushed
the
dev/graph
branch
9 times, most recently
from
a49f965 to
99be815
Compare
NeverRaR
force-pushed
the
dev/graph
branch
8 times, most recently
from
71634df to
44b77b9
Compare
ganyi1996ppo
approved these changes
May 29, 2025
NeverRaR
force-pushed
the
dev/graph
branch
2 times, most recently
from
5caa186 to
42544de
Compare
wangxiyuan
reviewed
May 29, 2025
| torch._logging.set_logs(recompiles=True) | ||
| self.torchair_graph_batch_sizes = additional_config.get( | ||
| "torchair_graph_batch_sizes", []) | ||
| if not isinstance(self.torchair_graph_batch_sizes, list): |
There was a problem hiding this comment.
we have enable_graph_mode to controller torchair, here named torchair_graph_batch_sizes, w'd better to use the same prefix. How about use torchair_graph for all case? cc @zzzzwwjj
|
I added a new ascendconfig to deal with all additional_config #1029 . The comment I added before can be addressed later. Please fix the merge conflict, then the PR is ready to go IMO. |
jianzs
approved these changes
May 30, 2025
NeverRaR
force-pushed
the
dev/graph
branch
3 times, most recently
from
bafde8a to
09b0d9d
Compare
|
test_scheduler.py should be updated as well. for example |
NeverRaR
force-pushed
the
dev/graph
branch
7 times, most recently
from
41e28c9 to
54f3a05
Compare
I noticed you are trying to fix scheduler UT via frequetly changes, this might the effective way to reproduce and run test locally |
NeverRaR
force-pushed
the
dev/graph
branch
4 times, most recently
from
5f20f3c to
53679a8
Compare
Signed-off-by: boying <897013703@qq.com>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 3, 2025
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 3, 2025
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 3, 2025
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Jun 3, 2025
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 3, 2025
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
David9857
pushed a commit
to David9857/vllm-ascend
that referenced
this pull request
Jun 3, 2025
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com>
momo609
pushed a commit
to momo609/vllm-ascend
that referenced
this pull request
Jun 4, 2025
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
feat: support compile torchair graph while warming up
Does this PR introduce any user-facing change?
How was this patch tested?